Preserve count order in numbered lists #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timolins
force-pushed
the
fix-numbered-list
branch
from
f6b657a to
681a581
Compare
|
Hey there! Sorry to be annoying but there still seems to be strange issues. Example this is the rendered page:
And this is the original notion page:
|
|
Oh wow. Should have tested it with your example page. Thanks for reporting. I'll take another look at it tomorrow. |
|
Thanks for taking the time to look at it. I was digging into it further and it looks like it's taking the actual block number as the first list number. So if my list is the fifth block on the page the numbered list will start at '5'. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4
Use the
startattribute of eacholelement to render the correct count.